Replace lychee with targeted ISO link validation for src/define.sh

Co-authored-by: kroese <5763256+kroese@users.noreply.github.com> Agent-Logs-Url: https://github.com/dockur/windows/sessions/828997f3-2043-4f5a-94df-76321b177c73
Add link validation step to check workflow using lychee-action
2026-03-23 12:16:08 +00:00 · 2026-03-23 12:06:03 +00:00 · 2026-03-23 11:31:04 +01:00 · 2026-03-23 11:26:50 +01:00 · 2026-03-09 11:50:01 -04:00 · 2026-01-13 13:43:48 +01:00
30 changed files with 76 additions and 55 deletions
@@ -15,6 +15,5 @@
    "onAutoForward": "ignore"
  }, 
  "dockerComposeFile": "../codespaces.yml",
-  "workspaceFolder": "/workspaces/windows",
  "initializeCommand": "docker system prune --all --force"
 }
@@ -15,6 +15,5 @@
    "onAutoForward": "ignore"
  }, 
  "dockerComposeFile": "../codespaces.yml",
-  "workspaceFolder": "/workspaces/windows",
  "initializeCommand": "docker system prune --all --force"
 }
@@ -15,6 +15,5 @@
    "onAutoForward": "ignore"
  }, 
  "dockerComposeFile": "../codespaces.yml",
-  "workspaceFolder": "/workspaces/windows",
  "initializeCommand": "docker system prune --all --force"
 }
@@ -15,6 +15,5 @@
    "onAutoForward": "ignore"
  }, 
  "dockerComposeFile": "../codespaces.yml",
-  "workspaceFolder": "/workspaces/windows",
  "initializeCommand": "docker system prune --all --force"
 }
@@ -15,6 +15,5 @@
    "onAutoForward": "ignore"
  }, 
  "dockerComposeFile": "../codespaces.yml",
-  "workspaceFolder": "/workspaces/windows",
  "initializeCommand": "docker system prune --all --force"
 }
@@ -15,6 +15,5 @@
    "onAutoForward": "ignore"
  }, 
  "dockerComposeFile": "../codespaces.yml",
-  "workspaceFolder": "/workspaces/windows",
  "initializeCommand": "docker system prune --all --force"
 }
@@ -15,6 +15,5 @@
    "onAutoForward": "ignore"
  }, 
  "dockerComposeFile": "../codespaces.yml",
-  "workspaceFolder": "/workspaces/windows",
  "initializeCommand": "docker system prune --all --force"
 }
@@ -15,6 +15,5 @@
    "onAutoForward": "ignore"
  }, 
  "dockerComposeFile": "../codespaces.yml",
-  "workspaceFolder": "/workspaces/windows",
  "initializeCommand": "docker system prune --all --force"
 }
@@ -15,6 +15,5 @@
    "onAutoForward": "ignore"
  }, 
  "dockerComposeFile": "../codespaces.yml",
-  "workspaceFolder": "/workspaces/windows",
  "initializeCommand": "docker system prune --all --force"
 }
@@ -15,6 +15,5 @@
    "onAutoForward": "ignore"
  }, 
  "dockerComposeFile": "../codespaces.yml",
-  "workspaceFolder": "/workspaces/windows",
  "initializeCommand": "docker system prune --all --force"
 }
@@ -15,6 +15,5 @@
    "onAutoForward": "ignore"
  }, 
  "dockerComposeFile": "../codespaces.yml",
-  "workspaceFolder": "/workspaces/windows",
  "initializeCommand": "docker system prune --all --force"
 }
@@ -15,6 +15,5 @@
    "onAutoForward": "ignore"
  }, 
  "dockerComposeFile": "../codespaces.yml",
-  "workspaceFolder": "/workspaces/windows",
  "initializeCommand": "docker system prune --all --force"
 }
@@ -15,6 +15,5 @@
    "onAutoForward": "ignore"
  }, 
  "dockerComposeFile": "../codespaces.yml",
-  "workspaceFolder": "/workspaces/windows",
  "initializeCommand": "docker system prune --all --force"
 }
@@ -15,6 +15,5 @@
    "onAutoForward": "ignore"
  }, 
  "dockerComposeFile": "../codespaces.yml",
-  "workspaceFolder": "/workspaces/windows",
  "initializeCommand": "docker system prune --all --force"
 }
@@ -15,6 +15,5 @@
    "onAutoForward": "ignore"
  }, 
  "dockerComposeFile": "../codespaces.yml",
-  "workspaceFolder": "/workspaces/windows",
  "initializeCommand": "docker system prune --all --force"
 }
@@ -15,6 +15,5 @@
    "onAutoForward": "ignore"
  }, 
  "dockerComposeFile": "../codespaces.yml",
-  "workspaceFolder": "/workspaces/windows",
  "initializeCommand": "docker system prune --all --force"
 }
@@ -15,6 +15,5 @@
    "onAutoForward": "ignore"
  }, 
  "dockerComposeFile": "../codespaces.yml",
-  "workspaceFolder": "/workspaces/windows",
  "initializeCommand": "docker system prune --all --force"
 }
@@ -15,6 +15,5 @@
    "onAutoForward": "ignore"
  }, 
  "dockerComposeFile": "../codespaces.yml",
-  "workspaceFolder": "/workspaces/windows",
  "initializeCommand": "docker system prune --all --force"
 }
@@ -15,6 +15,5 @@
    "onAutoForward": "ignore"
  }, 
  "dockerComposeFile": "../codespaces.yml",
-  "workspaceFolder": "/workspaces/windows",
  "initializeCommand": "docker system prune --all --force"
 }
@@ -15,6 +15,5 @@
    "onAutoForward": "ignore"
  }, 
  "dockerComposeFile": "../codespaces.yml",
-  "workspaceFolder": "/workspaces/windows",
  "initializeCommand": "docker system prune --all --force"
 }
@@ -15,6 +15,5 @@
    "onAutoForward": "ignore"
  }, 
  "dockerComposeFile": "../codespaces.yml",
-  "workspaceFolder": "/workspaces/windows",
  "initializeCommand": "docker system prune --all --force"
 }
@@ -15,6 +15,5 @@
    "onAutoForward": "ignore"
  },
  "dockerComposeFile": "codespaces.yml",
-  "workspaceFolder": "/workspaces/windows",
  "initializeCommand": "docker system prune --all --force"
 }
@@ -22,7 +22,7 @@ jobs:
    steps:
      -
        name: Checkout
-        uses: actions/checkout@v5
+        uses: actions/checkout@v6
        with:
          fetch-depth: 0
      -
@@ -9,7 +9,7 @@ jobs:
    steps:
      -
        name: Checkout
-        uses: actions/checkout@v5
+        uses: actions/checkout@v6
      -
        name: Run ShellCheck
        uses: ludeeus/action-shellcheck@master
@@ -33,3 +33,47 @@ jobs:
        uses: GrantBirki/json-yaml-validate@v4
        with:
          yaml_exclude_regex: ".*\\kubernetes\\.yml$"
+      -
+        name: Validate Links
+        run: |
+          errors=0
+          count=0
+          host=""
+          declare -A seen
+
+          check() {
+            local url="$1" http
+            http=$(curl -sSL -o /dev/null -w "%{http_code}" --max-time 10 -I -- "$url" 2>&1) || http="000"
+            [[ "$http" == 2* ]] && return 0
+            http=$(curl -sSL -o /dev/null -w "%{http_code}" --max-time 10 -r "0-0" -- "$url" 2>&1) || http="000"
+            [[ "$http" == 2* ]]
+          }
+
+          while IFS= read -r line; do
+            if [[ "$line" =~ ^[[:space:]]*local[[:space:]]+host=\"(https://[^\"]+)\" ]]; then
+              host="${BASH_REMATCH[1]%/}"
+              continue
+            fi
+            [[ "$line" =~ ^[[:space:]]*url=\"(.+)\" ]] || continue
+            val="${BASH_REMATCH[1]#/}"
+            if [[ "$val" == https://* ]]; then
+              url="$val"
+            elif [[ -n "$host" ]]; then
+              url="$host/$val"
+            else
+              continue
+            fi
+            [[ -v seen[$url] ]] && continue
+            seen[$url]=1
+            count=$((count + 1))
+            if check "$url"; then
+              echo "  OK: $url"
+            else
+              echo "FAIL: $url"
+              errors=$((errors + 1))
+            fi
+          done < "src/define.sh"
+
+          echo ""
+          printf '%d/%d links valid\n' "$(( count - errors ))" "$count"
+          (( errors == 0 ))
@@ -12,13 +12,15 @@ jobs:
  dockerHubDescription:
    runs-on: ubuntu-latest
    steps:
-    - uses: actions/checkout@v5
-    - 
-      name: Docker Hub Description
-      uses: peter-evans/dockerhub-description@v5
-      with:
-        username: ${{ secrets.DOCKERHUB_USERNAME }}
-        password: ${{ secrets.DOCKERHUB_TOKEN }}
-        repository: ${{ secrets.DOCKERHUB_REPO }}
-        short-description: ${{ github.event.repository.description }}
-        readme-filepath: ./readme.md
+      -
+        name: Checkout repo
+        uses: actions/checkout@v6
+      - 
+        name: Docker Hub Description
+        uses: peter-evans/dockerhub-description@v5
+        with:
+          username: ${{ secrets.DOCKERHUB_USERNAME }}
+          password: ${{ secrets.DOCKERHUB_TOKEN }}
+          repository: ${{ secrets.DOCKERHUB_REPO }}
+          short-description: ${{ github.event.repository.description }}
+          readme-filepath: ./readme.md
@@ -15,7 +15,7 @@ jobs:
    steps:
      -
        name: Checkout
-        uses: actions/checkout@v5
+        uses: actions/checkout@v6
      -
        name: Spelling
        uses: reviewdog/action-misspell@v1
@@ -3,7 +3,7 @@
 ARG VERSION_ARG="latest"
 FROM scratch AS build-amd64

-COPY --from=qemux/qemu:7.28 / /
+COPY --from=qemux/qemu:7.29 / /

 ARG TARGETARCH
 ARG DEBCONF_NOWARNINGS="yes"
@@ -19,7 +19,7 @@ RUN set -eu && \
        cabextract \
        libxml2-utils \
        libarchive-tools && \
-    wget "https://github.com/gershnik/wsdd-native/releases/download/v1.22/wsddn_1.22_${TARGETARCH}.deb" -O /tmp/wsddn.deb -q && \
+    wget "https://github.com/gershnik/wsdd-native/releases/download/v1.23/wsddn_1.23_${TARGETARCH}.deb" -O /tmp/wsddn.deb -q && \
    dpkg -i /tmp/wsddn.deb && \
    apt-get clean && \
    rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*
@@ -27,7 +27,7 @@ RUN set -eu && \
 COPY --chmod=755 ./src /run/
 COPY --chmod=755 ./assets /run/assets

-ADD --chmod=664 https://github.com/qemus/virtiso-whql/releases/download/v1.9.48-0/virtio-win-1.9.48.tar.xz /var/drivers.txz
+ADD --chmod=664 https://github.com/qemus/virtiso-whql/releases/download/v1.9.53-0/virtio-win-1.9.53.tar.xz /var/drivers.txz

 FROM dockurr/windows-arm:${VERSION_ARG} AS build-arm64
 FROM build-${TARGETARCH}
@@ -22,7 +22,7 @@ Windows inside a Docker container.

 ## Video 📺

-[![Youtube](https://img.youtube.com/vi/xhGYobuG508/0.jpg)](https://www.youtube.com/watch?v=xhGYobuG508)
+[![Youtube](https://img.youtube.com/vi/xhGYobuG508/maxresdefault.jpg)](https://www.youtube.com/watch?v=xhGYobuG508)

 ## Usage 🐳

@@ -1766,7 +1766,7 @@ prepareInstall() {
          echo ""
          echo "Call Domain.MoveHere(LocalAdminADsPath, \"$username\")"
          echo ""
-          echo "Set oLink = WshShell.CreateShortcut(WshShell.ExpandEnvironmentStrings(\"%userprofile%\\Desktop\\Shared.lnk\"))"
+          echo "Set oLink = WshShell.CreateShortcut(WshShell.SpecialFolders(\"Desktop\") & \"\\Shared.lnk\")"
          echo "With oLink"
          echo "  .TargetPath = \"\\\\host.lan\\Data\""
          echo "  .Save"
@@ -76,6 +76,12 @@ finish() {
  local pid
  local cnt=0
  local reason=$1
+  local pids=(
+        "/var/run/tpm.pid"
+        "/var/run/wsdd.pid"
+        "/var/run/samba/nmbd.pid"
+        "/var/run/samba/smbd.pid"
+      )

  touch "$QEMU_END"

@@ -114,21 +120,12 @@ finish() {
    fi
  fi

-  pid="/var/run/tpm.pid"
-  [ -s "$pid" ] && pKill "$(<"$pid")"
-  rm -f "$pid"
-
-  pid="/var/run/wsdd.pid"
-  [ -s "$pid" ] && pKill "$(<"$pid")"
-  rm -f "$pid"
-
-  pid="/var/run/samba/nmbd.pid"
-  [ -s "$pid" ] && pKill "$(<"$pid")"
-  rm -f "$pid"
-
-  pid="/var/run/samba/smbd.pid"
-  [ -s "$pid" ] && pKill "$(<"$pid")"
-  rm -f "$pid"
+  for pid in "${pids[@]}"; do
+      if [[ -s "$pid" ]]; then 
+          pKill "$(cat "$pid")"
+      fi
+      rm -f "$pid"
+  done 

  closeNetwork
Author	SHA1	Message	Date
copilot-swe-agent[bot]	79e2c0c14e	Replace lychee with targeted ISO link validation for src/define.sh Co-authored-by: kroese <5763256+kroese@users.noreply.github.com> Agent-Logs-Url: https://github.com/dockur/windows/sessions/828997f3-2043-4f5a-94df-76321b177c73	2026-03-23 12:16:08 +00:00
copilot-swe-agent[bot]	21a663a952	Add link validation step to check workflow using lychee-action Co-authored-by: kroese <5763256+kroese@users.noreply.github.com> Agent-Logs-Url: https://github.com/dockur/windows/sessions/503e047a-2b98-42fd-985e-3c3673736737	2026-03-23 12:06:03 +00:00
Kroese	8d4788f7c0	build: Update WSDD version to v1.23 (#1679 )	2026-03-23 11:31:04 +01:00
Kroese	8ec135d826	build: Update VirtIO drivers to v1.9.53 (#1678 )	2026-03-23 11:26:50 +01:00
huulme	0400f5f45d	docs: Higher quality video thumbnail (#1671 )	2026-03-09 11:50:01 -04:00
Azim Muradov	588969ae5f	fix: Path to "Desktop" folder on Windows XP (#1625 ) Fix path to "Desktop" folder to work correctly with different locales on Windows XP.	2026-01-13 13:43:48 +01:00
Kroese	c7aac1edcf	build: Update QEMU base image to v7.29 (#1583 )	2025-11-22 05:02:48 +01:00
renovate[bot]	ea03c67a04	chore(deps): update actions/checkout action to v6 (#1580 )	2025-11-21 12:38:58 +01:00
Gamal Moussa	bdb0488151	refactor: replace PID cleanup with loop (#1579 )	2025-11-20 08:49:24 +01:00
Kroese	ad6f87046a	build: Update VirtIO drivers to v1.9.49 (#1570 )	2025-11-14 07:18:24 +01:00
Kroese	e7a3894210	fix: Update Workspaces configuration (#1569 )	2025-11-14 06:26:07 +01:00